-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EF Core CI testing using Helix queues #19917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/helix3
branch
7 times, most recently
from
February 19, 2020 01:34
c6517dd
to
bfb9960
Compare
smitpatel
force-pushed
the
smit/helix3
branch
11 times, most recently
from
February 19, 2020 04:13
51f79b0
to
bd3f958
Compare
smitpatel
changed the title
Add testing on helix
Add EF Core CI testing using Helix queues
Feb 19, 2020
smitpatel
force-pushed
the
smit/helix3
branch
from
February 19, 2020 05:15
bd3f958
to
09e3d00
Compare
This is ready for review. |
HaoK
reviewed
Feb 19, 2020
HaoK
reviewed
Feb 19, 2020
HaoK
approved these changes
Feb 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks a lot simpler than ours with the newish XunitPublish stuff, I will see if aspnetcore can take advantage of that as well
dougbu
previously requested changes
Feb 19, 2020
test/EFCore.Relational.Specification.Tests/EFCore.Relational.Specification.Tests.csproj
Show resolved
Hide resolved
smitpatel
force-pushed
the
smit/helix3
branch
from
February 19, 2020 22:01
cd392e4
to
50858ae
Compare
smitpatel
changed the title
Add EF Core CI testing using Helix queues
[WIP] Add EF Core CI testing using Helix queues
Feb 19, 2020
On-Hold. |
dougbu
reviewed
Feb 19, 2020
smitpatel
force-pushed
the
smit/helix3
branch
from
February 19, 2020 23:05
ac6deb2
to
802bbaa
Compare
smitpatel
changed the title
[WIP] Add EF Core CI testing using Helix queues
Add EF Core CI testing using Helix queues
Feb 20, 2020
This is ready for review now. |
dougbu
approved these changes
Feb 20, 2020
- Adds coverage for testing using - WindowsServer 2016-Datacenter with localdb - macOS 10.14 - Ubuntu 18.04-LTS - Currently tests are run separately based on OS type win/non-win due to #19964 - Uses anonymous auth from public build and access token from internal build - Automatically adds all test projects from test folder - All telemetry is enabled for reporting - EnableAzurePipelinesReporter - FailOnTestFailure - EnableXUnitReporter - FailOnMissionControlTestFailure - Validated internal builds also uses helix for testing using HelixAccessToken - Checking FullTextSearch on SqlServer has been put in try-catch (Helix run threw exception of localdb not found) Resolves #19857
smitpatel
force-pushed
the
smit/helix3
branch
from
February 20, 2020 01:12
802bbaa
to
eeaa0ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds coverage for testing using
Currently tests are run separately based on OS type win/non-win due to Test binaries compiled on windows fail on linux platform #19964
Uses anonymous auth from public build and access token from internal build
Automatically adds all test projects from test folder
All telemetry is enabled for reporting
Validated internal builds also uses helix for testing using HelixAccessToken
Checking FullTextSearch on SqlServer has been put in try-catch (Helix run threw exception of localdb not found)
Resolves #19857