Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EF Core CI testing using Helix queues #19917

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Add EF Core CI testing using Helix queues #19917

merged 1 commit into from
Feb 20, 2020

Conversation

smitpatel
Copy link
Member

@smitpatel smitpatel commented Feb 13, 2020

  • Adds coverage for testing using

    • WindowsServer 2016-Datacenter with localdb
    • macOS 10.14
    • Ubuntu 18.04-LTS
  • Currently tests are run separately based on OS type win/non-win due to Test binaries compiled on windows fail on linux platform #19964

  • Uses anonymous auth from public build and access token from internal build

  • Automatically adds all test projects from test folder

  • All telemetry is enabled for reporting

    • EnableAzurePipelinesReporter
    • FailOnTestFailure
    • EnableXUnitReporter
    • FailOnMissionControlTestFailure
  • Validated internal builds also uses helix for testing using HelixAccessToken

  • Checking FullTextSearch on SqlServer has been put in try-catch (Helix run threw exception of localdb not found)

Resolves #19857

@smitpatel smitpatel force-pushed the smit/helix3 branch 7 times, most recently from c6517dd to bfb9960 Compare February 19, 2020 01:34
@smitpatel smitpatel changed the title [WIP] Add testing on helix Add testing on helix Feb 19, 2020
@smitpatel smitpatel force-pushed the smit/helix3 branch 11 times, most recently from 51f79b0 to bd3f958 Compare February 19, 2020 04:13
@smitpatel smitpatel changed the title Add testing on helix Add EF Core CI testing using Helix queues Feb 19, 2020
@smitpatel
Copy link
Member Author

This is ready for review.

@smitpatel smitpatel requested review from bricelam, HaoK, jonfortescue and a team February 19, 2020 05:15
eng/helix.proj Show resolved Hide resolved
eng/helix.proj Show resolved Hide resolved
Copy link
Member

@HaoK HaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks a lot simpler than ours with the newish XunitPublish stuff, I will see if aspnetcore can take advantage of that as well

dougbu
dougbu previously requested changes Feb 19, 2020
azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Show resolved Hide resolved
azure-pipelines.yml Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
global.json Show resolved Hide resolved
@smitpatel smitpatel changed the title Add EF Core CI testing using Helix queues [WIP] Add EF Core CI testing using Helix queues Feb 19, 2020
@smitpatel
Copy link
Member Author

On-Hold.

@smitpatel smitpatel changed the title [WIP] Add EF Core CI testing using Helix queues Add EF Core CI testing using Helix queues Feb 20, 2020
@smitpatel
Copy link
Member Author

This is ready for review now.

azure-pipelines.yml Outdated Show resolved Hide resolved
- Adds coverage for testing using
  - WindowsServer 2016-Datacenter with localdb
  - macOS 10.14
  - Ubuntu 18.04-LTS

- Currently tests are run separately based on OS type win/non-win due to #19964
- Uses anonymous auth from public build and access token from internal build
- Automatically adds all test projects from test folder
- All telemetry is enabled for reporting
  - EnableAzurePipelinesReporter
  - FailOnTestFailure
  - EnableXUnitReporter
  - FailOnMissionControlTestFailure
- Validated internal builds also uses helix for testing using HelixAccessToken
- Checking FullTextSearch on SqlServer has been put in try-catch (Helix run threw exception of localdb not found)

Resolves #19857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run EF Core C.I. tests on Helix
6 participants