Add view support to the relational model API #19971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
approved these changes
Feb 20, 2020
smitpatel
reviewed
Feb 20, 2020
smitpatel
reviewed
Feb 20, 2020
smitpatel
reviewed
Feb 20, 2020
smitpatel
reviewed
Feb 20, 2020
| new IViewColumn FindColumn([NotNull] string name); | ||
|
|
||
| /// <summary> | ||
| /// The view definition or <c>null</c> if this view is not managed by migrations. |
There was a problem hiding this comment.
Interesting if you specify a view definition we will create it for you in migrations hence managed by migrations. 
There was a problem hiding this comment.
Yes, that's the design...
smitpatel
reviewed
Feb 20, 2020
smitpatel
reviewed
Feb 20, 2020
smitpatel
reviewed
Feb 20, 2020
|
@smitpatel @ajcvickers @bricelam I've reverted the breaking change to |
Use the new model in the query pipeline Fixes #12846
smitpatel
reviewed
Feb 20, 2020
| @@ -411,7 +427,17 @@ public static RelationalTypeMapping GetRelationalTypeMapping([NotNull] this IPro | |||
| /// <param name="property"> The property. </param> | |||
| /// <returns> The type mapping, or null if none was found. </returns> | |||
| [DebuggerStepThrough] | |||
| [Obsolete("Use FindRelationalTypeMapping")] | |||
AndriySvyryd
force-pushed
the
Issue12846
branch
from
5e9d751
to
8ea444b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new model in the query pipeline
Fixes #12846