Nested ambient transaction #20012
Merged
Nested ambient transaction #20012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added resource string for further use to indicate that a parent transaction is completed before child one.
Allowed several nested ambient transactions to be processed. Main scenario is when one transaction with TransactionScopeOption.RequiresNew is created inside another one.
Added two unit tests to check nested ambient scenarios - one for normal flow when both transaction are committed, another for a case when child transaction is committed, and parent is not.
…_Ambient_Transaction
|
|
|
@dshuvaev You need to sign the CLA before we can look at this PR. |
I am getting approval to do so. |
@ajcvickers It is signed. Thank you |
smitpatel
reviewed
Feb 25, 2020
| @@ -548,11 +553,16 @@ private void ClearTransactions(bool clearAmbient) | |||
| { | |||
| CurrentTransaction = null; | |||
| EnlistedTransaction = null; | |||
| if (clearAmbient | |||
| && _ambientTransaction != null) | |||
| if (clearAmbient && _ambientTransactions.Any()) | |||
There was a problem hiding this comment.
_ambientTransactions.Count > 0
"Count" in this case works better than "Any"
AndriySvyryd
approved these changes
Feb 27, 2020
|
@dshuvaev Thanks for your contribution! |
smitpatel
reviewed
Feb 27, 2020
| { | ||
| Dependencies.TransactionLogger.AmbientTransactionWarning(this, DateTimeOffset.UtcNow); | ||
| var rootTransaction = _ambientTransactions.Any() && _ambientTransactions.TryPeek(out var transaction) ? transaction : null; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed several nested ambient transactions to be processed. Main scenario is when one transaction with TransactionScopeOption.RequiresNew is created inside another one. Thus when child transaction is complete its results are persisted, while parent transaction can be rejected.