[release/3.1] Microsoft.Data.Sqlite: Set temp and data directory on UWP #20077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
commented
Feb 26, 2020
|
|
||
| namespace Microsoft.Data.Sqlite.Utilities | ||
| { | ||
| internal class ApplicationDataHelper |
There was a problem hiding this comment.
Note, this is the same code we had in 1.1
bricelam
changed the title
bricelam
changed the title
bricelam
commented
Feb 26, 2020
ajcvickers
approved these changes
Feb 28, 2020
|
Approved by tactics for 3.1.4. Wait for branch to open before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19754
Description
The native SQLite interop library we depend on (SQLitePCL.raw) made a breaking change to stop setting the temp and data directories on UWP. Our guidance was for users to manually set these in their application. If users don't set these and specify a relative database file in their connection string, they'll get a SQLite error:
Customer Impact
Several customers are encountering the error without understanding why or how to fix it.
By reintroducing code to set these directories automatically for the user, it will lower the barrier to get started using Microsoft.Data.Sqlite and EF Core on UWP.
How found
Reported by multiple customers.
Test coverage
Manually verified that this works on UWP using both the version of SQLite that we include and winsqlite3.dll. Also verified that it works on .NET Native.
Regression?
Yes, from 2.2 to 3.0
Risk
Low. This is a no-op on all platforms besides UWP. There is a flag to disable the new behavior if it proves to be problematic.