Minor cleanup for queryable function support #20139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't! I am already working in this area and this will just cause merge conflicts! |
|
No worries, I can rebase this (if necessary!) after you finish your work. Feel free to close this, or just ping me here when you're done for me to rebase. |
|
|
|
Can you resolve existing conflicts? #20178 can cause some conflicts but nothing major. Either PR going first is fine. |
|
@smitpatel working on merge conflicts isn't my preferred pre-bedtime activity...! Go ahead and merge yours, I'll take care of resolving conflicts tomorrow. |
|
@smitpatel already did thumbs-up so I've lost my chance... |
roji
force-pushed
the
QueryableFunctionCleanup
branch
from
bf4ee6f
to
9e72ab7
Compare
|
Rebased, not too much left! |
smitpatel
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @smitpatel @pmiddleton