Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Print better expression trees #20147

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Query: Print better expression trees #20147

merged 1 commit into from
Mar 3, 2020

Conversation

smitpatel
Copy link
Member

  • Removed parenthesis around IPrintableExpression since it was making printing of query roots bad.
    • Individual expression should decide if it wants to add parenthesis around it.
  • Reduce the expression tree before printing in Navigation expansion for more human readable form.

Required for #20146

@smitpatel
Query: Print better expression trees
40f86db 
- Removed parenthesis around IPrintableExpression since it was making printing of query roots bad.
  - Individual expression should decide if it wants to add parenthesis around it.
- Reduce the expression tree before printing in Navigation expansion for more human readable form.

Required for #20146
@smitpatel smitpatel requested review from allenstecat and a team and removed request for allenstecat March 3, 2020 20:51
@smitpatel
Copy link
Member Author

@dotnet/efcore - Looking for quick review since it is required for my current work in #20146

@smitpatel smitpatel merged commit c07d362 into master Mar 3, 2020
@smitpatel smitpatel deleted the smit/expressionprinter branch March 3, 2020 21:17
@ajcvickers ajcvickers mentioned this pull request Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam approved these changes

@maumar maumar maumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smitpatel @bricelam @maumar