Query: Introduce custom query root expression #20152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Mar 4, 2020
- Use expression for query roots rather tha constant of entity queryable - Make it easy to access EntityType without need of any interface - Make IAsyncQueryProvider public as it is part of QueryRootExpression - A query root contains both entity type and query provider so that multiple context cannot be used inside same query - Update expression printing of DbSet to take care of shared type entity type - Fix bug to compare query roots of shared type entity type more accurately - Remove IEntityQueryable interface, detaching query provider happens on query root expression - Remove IsEntityQueryable method as we no longer create constant expression of entity queryable Part of #20146
When entity queryables are injected while compiling a query, they don't need query provider External queries only need query provider to make sure that we are using DbSets from same context
- Avoids any specific processing in core provider - Takes care of parameterization correctly - Also improved parameter extraction by creating parameter for any expression outside of lambda even when not a method call argument Part of #20146
- Avoids having to do special processing in other visitors - Visit's method's argument correctly in other visitor (this means that if there is a navigation expansion required for a parameter it will be done automatically) - Remove Nav expansion factory not needed anymore - Rename ExpressionPrinter.VisitList to VisitCollection and take IReadOnlyCollection, that is what most expression uses. - Remove unnecessary exception message. They are part of a larger work item. Resolves #20146
smitpatel
force-pushed
the
smit/queryrootpart1
branch
from
ae392d3
to
363d37c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #20146
Query: Allow creating query roots without provider
When entity queryables are injected while compiling a query, they don't need query provider
External queries only need query provider to make sure that we are using DbSets from same context