Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Introduce custom query root for TVF #20165

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Query: Introduce custom query root for TVF #20165

merged 1 commit into from
Mar 4, 2020
+253 −222

Conversation

smitpatel
Copy link
Member

  • Avoids having to do special processing in other visitors
  • Visit's method's argument correctly in other visitor (this means that if there is a navigation expansion required for a parameter it will be done automatically)
  • Remove Nav expansion factory not needed anymore
  • Rename ExpressionPrinter.VisitList to VisitCollection and take IReadOnlyCollection, that is what most expression uses.
  • Remove unnecessary exception message. They are part of a larger work item.

Resolves #20146

@smitpatel
Query: Introduce custom query root for TVF
4e49510 
- Avoids having to do special processing in other visitors
- Visit's method's argument correctly in other visitor (this means that if there is a navigation expansion required for a parameter it will be done automatically)
- Remove Nav expansion factory not needed anymore
- Rename ExpressionPrinter.VisitList to VisitCollection and take IReadOnlyCollection, that is what most expression uses.
- Remove unnecessary exception message. They are part of a larger work item.

Resolves #20146
@smitpatel smitpatel mentioned this pull request Mar 4, 2020
Closed
@smitpatel
Copy link
Member Author

@roji - Can you take a look at this branch and see if you still need fix for the convert node removal work you did in the other PR?

@roji
Copy link
Member

roji commented Mar 4, 2020

@smitpatel confirmed that with your branch all my tests are green, thanks!

@smitpatel smitpatel merged commit b16b64d into smit/queryrootpart2 Mar 4, 2020
@smitpatel smitpatel deleted the smit/queryrootpart3 branch March 4, 2020 20:54
@smitpatel smitpatel linked an issue Mar 4, 2020 that may be closed by this pull request
Query: Introduce an Expression for query root #20146
Closed
@ajcvickers ajcvickers mentioned this pull request Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maumar maumar maumar approved these changes

@AndriySvyryd AndriySvyryd Awaiting requested review from AndriySvyryd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query: Introduce an Expression for query root
3 participants
@smitpatel @roji @maumar