[TINY] Use sql function IsNullable property to determine its nullability, rather than always assume it's nullable #20177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Mar 4, 2020
| @@ -1015,8 +1015,7 @@ protected override Expression VisitSqlFunction(SqlFunctionExpression sqlFunction | |||
|
|
|||
| if (sqlFunctionExpression.IsNiladic) | |||
| { | |||
| // TODO: #18555 | |||
| _nullable = true; | |||
| _nullable = sqlFunctionExpression.IsNullable; | |||
There was a problem hiding this comment.
Can move this outside instead of repeating here and below.
There was a problem hiding this comment.
visiting arguments will override _nullable value
There was a problem hiding this comment.
OK, thanks for explaining - stateful visitor pattern isn't easy :)
There was a problem hiding this comment.
This makes me think again it may make sense to keep having VisitInternal returning the nullability of the visited node, and restoring _nullable to what it was when it was called. This would make it clearer to see what gets modified when.
…ther than always assume it's nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny fix that was missed when fixing #18555