Introduce complete discriminator mapping #20193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/completediscriminatormapping
branch
from
2afae06
to
de737de
Compare
AndriySvyryd
reviewed
Mar 5, 2020
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
reviewed
Mar 5, 2020
AndriySvyryd
reviewed
Mar 5, 2020
AndriySvyryd
reviewed
Mar 5, 2020
AndriySvyryd
reviewed
Mar 5, 2020
AndriySvyryd
reviewed
Mar 5, 2020
AndriySvyryd
reviewed
Mar 5, 2020
test/EFCore.Sqlite.FunctionalTests/Query/IncompleteMappingInheritanceSqliteFixture.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
reviewed
Mar 5, 2020
AndriySvyryd
reviewed
Mar 5, 2020
test/EFCore.Specification.Tests/Query/InheritanceFixtureBase.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
reviewed
Mar 5, 2020
test/EFCore.Specification.Tests/Query/InheritanceFixtureBase.cs
Outdated
Show resolved
Hide resolved
smitpatel
force-pushed
the
smit/completediscriminatormapping
branch
from
de737de
to
f8e5211
Compare
|
Updated. |
AndriySvyryd
reviewed
Mar 5, 2020
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
reviewed
Mar 5, 2020
test/EFCore.Design.Tests/Migrations/ModelSnapshotSqlServerTest.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Mar 6, 2020
- Add fluent API IsComplete over DiscriminatorBuilder - In query if mapping is complete - Don't generate predicate when creating Select for an entityType - Don't apply predicate when doing OfType of derived type when the discriminator is not needed Current default: Mapping is incomplete unless user uses fluent API to mark it as complete. Resolves #18106
smitpatel
force-pushed
the
smit/completediscriminatormapping
branch
from
f8e5211
to
8139586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current default: Mapping is incomplete unless user uses fluent API to mark it as complete.
Resolves #18106