Partial Fix for 6674. Allow inline configuration of Navigations as they are created #20195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lajones
commented
Mar 6, 2020
lajones
commented
Mar 6, 2020
AndriySvyryd
reviewed
Mar 6, 2020
smitpatel
reviewed
Mar 6, 2020
smitpatel
reviewed
Mar 6, 2020
…ithOne. Generic and non-generic.
lajones
force-pushed
the
20200305_Issue6674_02
branch
from
c7e8bdd
to
1c26c4d
Compare
lajones
changed the title
|
@AndriySvyryd - this is the fix for all generic and non-generic updates to HasOne/HasMany/WithOne/WithMany except many-to-many. I'd like to get this checked in before it gets too unwieldy and continue to work on the rest separately (which includes the update to MemberInfo instead of PropertyInfo). |
AndriySvyryd
reviewed
Mar 7, 2020
AndriySvyryd
reviewed
Mar 7, 2020
AndriySvyryd
reviewed
Mar 7, 2020
AndriySvyryd
reviewed
Mar 7, 2020
…ectly Updated WithOneBuilder calls to do nav config. Extracted IConventionNavigationBuilder.
lajones
commented
Mar 8, 2020
AndriySvyryd
reviewed
Mar 8, 2020
|
|
||
| navigationConfiguration( | ||
| new NavigationBuilder(navigation)); | ||
| } |
There was a problem hiding this comment.
I'd suggest extracting this to a common method as well
There was a problem hiding this comment.
I looked into it. They all do slightly different things - navigationName vs navigationMember etc.
There was a problem hiding this comment.
That's fine, you can abstract them as MemberIdentity, see WithOneBuilder
AndriySvyryd
reviewed
Mar 8, 2020
AndriySvyryd
reviewed
Mar 8, 2020
|
Add |
Abstract into HasOneBuilder().
|
All comments addressed. |
AndriySvyryd
approved these changes
Mar 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Partial Fix for #6674. Allow inline configuration of Navigations as they are created.
Note: there's more to come. At the moment this just supports the WithMany(...). HasOne(...) syntax, but I know I need to do the others too.