Partial fix for 6674. Can configure navigations between owner and owned types. #20222
Conversation
| /// </param> | ||
| /// <returns> The same builder instance so that multiple configuration calls can be chained. </returns> | ||
| public virtual OwnedNavigationBuilder OwnerToOwnedNavigation( | ||
| [NotNull] Action<NavigationBuilder> navigationConfiguration) |
There was a problem hiding this comment.
Note: I'm open to renaming this and the one below.
Advantages: it makes the Owner-to-Owned-Type relationship clear.
Disadvantages: it's easy to get OwnerToOwnedNavigation and OwnedToOwnerNavigation mixed up.
There was a problem hiding this comment.
Thinking about this name the alternative of having OwnsOne with two lambdas doesn't appear that bad.
You can rename this to WithOwnedNavigation for now and we can discuss in design meeting.
There was a problem hiding this comment.
There is a problem with putting 2 lambdas on OwnsOne(). We already have the two methods below.
public virtual OwnedNavigationBuilder OwnsOne(
[NotNull] string ownedTypeName,
[NotNull] string navigationName)and
public virtual EntityTypeBuilder OwnsOne(
[NotNull] string ownedTypeName,
[NotNull] string navigationName,
[NotNull] Action<OwnedNavigationBuilder> buildAction)
{But if you add an extra optional Action<NavigationBuilder> parameter to both and try to use them, the compiler complains saying it doesn't know whether you're calling the first one or the second one with the 4th parameter null. I.e. nb => nb.UsePropertyAccessMode(...) is valid on both of them.
There was a problem hiding this comment.
We would only add it to the overload that has the buildAction
| /// An action which configures the navigation property from the owned type to its owner. | ||
| /// </param> | ||
| /// <returns> The same builder instance so that multiple configuration calls can be chained. </returns> | ||
| public virtual OwnedNavigationBuilder OwnedToOwnerNavigation( |
There was a problem hiding this comment.
This method is not needed. just add the parameter to WithOwner()
Partial fix for #6674. Adds the ability to configure navigations between owner and owned types.