Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure the navigation on dependent side of Owned-types #20276

Closed

Conversation

lajones
Copy link
Contributor

@lajones lajones commented Mar 13, 2020

Fix for #6674 . Based on PR #20271

This adds the last part - being able to configure the dependent side navigation of an Owned-type relationship.

(This PR will need to be merged with the work in #20271 before committing).

…ntityBuilder. Added OnetoMany, ManyToOne, ManyToMany, OneToOne and principal side of the Owned Type tests.
@lajones lajones self-assigned this Mar 13, 2020
@lajones lajones mentioned this pull request Mar 13, 2020
@AndriySvyryd
Copy link
Member

This isn't the last part for #6674. We still need to handle fields in the expression as I've mentioned previously. And we should also add HasField to NavigationBuilder to allow configuring a field that's not found by convention.

@lajones
Copy link
Contributor Author

lajones commented Mar 13, 2020

You mean #11610? I'm going to open a new bug and track that separately.

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Mar 14, 2020

Rebase on master and create an issue for the remaining work

@lajones
Copy link
Contributor Author

lajones commented Mar 14, 2020

@AndriySvyryd Note #11610 already has a bug - it's #11410 - which is assigned to me.

@AndriySvyryd
Copy link
Member

@lajones Ok, but where are you tracking removing the "old way" and adding HasField?

@lajones
Copy link
Contributor Author

lajones commented Mar 14, 2020

Created #20281 to track the HasField issue. #6674 will track "removing the old way".

@lajones
Copy link
Contributor Author

lajones commented Mar 14, 2020

Closing this in favor of #20282 (which commits to master).

@lajones lajones closed this Mar 14, 2020
@smitpatel smitpatel deleted the 20200312_Issue6674_Nav_WithOwned_15 branch March 16, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants