Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Data.Sqlite: Test against e_sqlcipher and winsqlite3 #20301

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Microsoft.Data.Sqlite: Test against e_sqlcipher and winsqlite3 #20301

merged 1 commit into from
Mar 26, 2020

Conversation

bricelam
Copy link
Contributor

No description provided.

@bricelam bricelam requested a review from dougbu as a code owner March 16, 2020 16:05
@bricelam bricelam requested review from smitpatel and removed request for dougbu March 16, 2020 16:05
@bricelam
Copy link
Contributor Author

Nuts; ordering issue. The Helix SDK is not extensible at all.

@bricelam
Copy link
Contributor Author

@ajcvickers It looks like we're not compatible with the version of winsqlite3.dll on Helix.
@smitpatel Do you know what version of Windows the Windows.10.Amd64.Open pool uses?

@bricelam
Copy link
Contributor Author

bricelam commented Mar 26, 2020

Errors:

  • no such table: pragma_index_list (product issue)
  • functions prohibited in partial index WHERE clauses (test issue)

@smitpatel
Copy link
Member

image

What version of windows do we need?

@bricelam
Copy link
Contributor Author

bricelam commented Mar 26, 2020

I'm trying to find info on what version of SQLite is included in what version of Windows...

Looks like we need SQLite 3.16.0 or higher.

@smitpatel
Copy link
Member

Here is all the images. https://helix.dot.net/ Couldn't find specific Sqlite version.

@bricelam
Copy link
Contributor Author

bricelam commented Mar 26, 2020

SQLite Windows
3.11.1 1607 (RS1, 10.0.14393)
3.15.2 1703 (RS2, 10.0.15063)
3.19.3 1709 (RS3, 10.0.16299)
3.21.0 1803 (RS4, 10.0.17134)
3.23.3 1809 (RS5, 10.0.17763)
3.25.3 1903 (19H1, 10.0.18362)
3.29.0 TBD (>=18959)

@smitpatel
Copy link
Member

We could use a different windows queue for winsqlite3 testing.
We have most of required version for both win10 client and datacenter.

@bricelam
Copy link
Contributor Author

I'm just going to skip the tests if the version is too low

@bricelam
Copy link
Contributor Author

@ajcvickers Are you OK saying the minimum supported version of SQLite is 3.16.0? Alternatively, we could update SqliteDataReader.GetSchemaTable() to be compatible with lower versions.

@ajcvickers
Copy link
Member

@bricelam Yes. Especially as we have a way to bring your own DLL.

@bricelam bricelam merged commit bf325f0 into dotnet:master Mar 26, 2020
@bricelam bricelam deleted the tripco branch March 27, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants