Revert "Fix to #18147 - Where bool column needs to convert to equalit…

[smitpatel]

…y when value converter is applied"

This reverts commit e922850.

[smitpatel]

Will merge on build pass. We can discuss later in #18147

[roji]

Note to @smitpatel @maumar: when syncing EFCore.PG against ac46335 (latest nuget available), I get a test failure on Where_bool_gets_converted_to_equality_when_value_conversion_is_used_using_EFProperty, where PostgreSQL complains that WHERE must receive a boolean type, not character varying:

SELECT b."BlogId", b."Discriminator", b."IndexerVisible", b."IsVisible", b."Url", b."RssUrl"
        FROM "Blog" AS b
        WHERE b."IsVisible"

(same with Where_bool_gets_converted_to_equality_when_value_conversion_is_used_using_indexer)

I see the change has been reverted already, I guess just keep in mind for when fixing again.

[roji]

Oops, was looking at the wrong commit. I'm actually synced against 8771406, which already has this revert inside it - the test still fails. Do you guys want a new issue to track this?

[smitpatel]

#18147 has been re-opened. I left skipped tests behind in this PR. Tests are not skipped in specs since SqlServer can run them. Individual providers have skipped them.

You need some sleep @roji

[roji]

Thanks @smitpatel, good to know. And I definitely do need some sleep at some point.