Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AnnotatableBuilder public #20448

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Make AnnotatableBuilder public #20448

merged 1 commit into from
Mar 30, 2020

Conversation

AndriySvyryd
Copy link
Member

Rename InternalRelationshipBuilder to InternalForeignKeyBuilder

smitpatel
smitpatel reviewed Mar 28, 2020
View reviewed changes
Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the rationale behind changing InternalRelationshipBuilder to InternalForeignKeyBuilder?
If changed, what would be the difference between a Relationalship vs ForeignKey?
If no change then we have APIs called HasRelationship etc, should those be changed also?

src/EFCore.Relational/Metadata/IDbFunctionParameter.cs Outdated Show resolved Hide resolved
src/EFCore/Metadata/Builders/InvertibleRelationshipBuilderBase.cs Outdated Show resolved Hide resolved
src/EFCore/Metadata/Internal/InternalSkipNavigationBuilder.cs Outdated Show resolved Hide resolved
@AndriySvyryd
Copy link
Member Author

InternalRelationshipBuilder renamed because it only builds foreign keys. Skip navigations also represent a relationship.

@AndriySvyryd
Make AnnotatableBuilder public
c42afa1 
Rename InternalRelationshipBuilder to InternalForeignKeyBuilder
@AndriySvyryd AndriySvyryd merged commit c42afa1 into master Mar 30, 2020
@AndriySvyryd AndriySvyryd deleted the AnnotatableBuilder branch March 30, 2020 18:31
@ajcvickers ajcvickers mentioned this pull request Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@lajones lajones lajones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriySvyryd @smitpatel @lajones