Cleanup of value generation visibility and namespaces #20457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Mar 29, 2020
src/EFCore.Relational/ValueGeneration/Internal/TemporaryDateTimeValueGenerator.cs
Outdated
Show resolved
Hide resolved
Fixes #20386 * Moved temp generators only used for relational corner cases to relational assembly. * Made TemporaryNumberValueGeneratorFactory public because temp numbers are useful outside of relational. For example, Cosmnos. * Made non-temp value and string and binary generators public since they can be generally useful and are used from providers. No longer any use of internal code across boundaries.
ajcvickers
force-pushed
the
HireOrFire0328
branch
from
9b1369c
to
eb9d34a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20386
No longer any use of internal code across boundaries.