Fix for 11614 - Adding HasPrecision() APIs #20468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lajones
changed the title
src/EFCore.Design/Scaffolding/Internal/ScaffoldingTypeMapper.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Storage/Internal/DbParameterCollectionExtensions.cs
Show resolved
Hide resolved
src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeOffsetTypeMapping.cs
Show resolved
Hide resolved
Now process all facets for all TypeMappings in Scaffolding. Update format of datetime parameters to include the fractional seconds and update tests to match.
lajones
force-pushed
the
20200329_Issue11614_14
branch
from
de5ff2c
to
e917609
Compare
lajones
commented
Mar 31, 2020
src/EFCore.SqlServer/Storage/Internal/SqlServerTypeMappingSource.cs
Outdated
Show resolved
Hide resolved
lajones
force-pushed
the
20200329_Issue11614_14
branch
from
e917609
to
8b74d83
Compare
AndriySvyryd
approved these changes
Mar 31, 2020
|
Note: many thanks to @SARAVANA1501, in particular his pull request #18237. I used that to get started on this. |
|
Any chance of adding this as an attribute also? Thanks. |
|
@Tommigun1980 See #17914 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11614.
Added
HasPrecision(precision)andHasPrecision(precision, scale)toPropertyBuilder.Updates to scaffolding and migrations and to process all facets for all TypeMappings in Scaffolding.
Updated tests to match.