Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for 20303. #20477

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Fix for 20303. #20477

merged 1 commit into from
Apr 1, 2020

Conversation

lajones
Copy link
Contributor

@lajones lajones commented Mar 31, 2020 •
edited
Loading

Throw if cannot set IsUnique because the NavProp has the opposite multiplicity.

Fixes #20303.

@lajones lajones self-assigned this Mar 31, 2020
AndriySvyryd
AndriySvyryd requested changes Mar 31, 2020
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also throw in InternalForeignKeyBuilder.IsUnique

@lajones
Copy link
Contributor Author

lajones commented Apr 1, 2020

@AndriySvyryd Completely updated this PR to take the new approach.

@lajones lajones changed the title Partial fix for 20303. Fix for 20303. Apr 1, 2020
@lajones lajones merged commit 7eac3aa into master Apr 1, 2020
@lajones lajones deleted the 20200330_Issue20303_01 branch April 1, 2020 01:37
@ajcvickers ajcvickers mentioned this pull request Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees

@lajones lajones

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw early when user mistakenly uses OwnsOne() but points to a collection
2 participants
@lajones @AndriySvyryd