Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Check if parameter.Name is not null before comparing it with q… #20503

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

smitpatel
Copy link
Member

…uery parameter

Resolves #20485

  • Parameters which are used inside lambda should get replaced with appropriate shaper/selector.
  • All other parameters should be query parameters otherwise it is an error.

Resolves #18502

  • Non query parameters should not get translated. Query parameters which are translated will always have value in QueryContext.

@smitpatel smitpatel requested a review from a team April 2, 2020 21:40
…uery parameter

Resolves #20485
- Parameters which are used inside lambda should get replaced with appropriate shaper/selector.
- All other parameters should be query parameters otherwise it is an error.

Resolves #18502
- Non query parameters should not get translated. Query parameters which are translated will always have value in QueryContext.
@smitpatel smitpatel force-pushed the smit/parameterNamesCanBeNull branch from e88ea7d to 29842da Compare April 6, 2020 18:19
@smitpatel smitpatel merged commit 24b71e1 into master Apr 6, 2020
@smitpatel smitpatel deleted the smit/parameterNamesCanBeNull branch April 6, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants