Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Parameterize components of NewExpression when possible #20522

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Query: Parameterize components of NewExpression when possible #20522

merged 1 commit into from
Apr 3, 2020
+51 −4

Commits on Apr 3, 2020

  1. Query: Parameterize components of NewExpression when possible 

    Issue: When evaluating MemberInitExpression/ListInitExpression, we skipped visiting inner NewExpression if other components were not evaluatable.
We did this since if we cannot evaluate NewExpression otherwise due to structure of expression which does not take ParmeterExpression in place of NewExpression.
But existing logic skipped visiting NewExpression altogether, leaving behind closure variable inside NewExpression.
Fix: Visit NewExpression so that it's components are marked for parameterization and explicitly disallow evaluating NewExpression

Resolves #20502
    @smitpatel
    smitpatel committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    d403a95 View commit details
    Browse the repository at this point in the history