Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up of pubternal usage for building/using internal service provider #20535

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Clean up of pubternal usage for building/using internal service provider #20535

merged 1 commit into from
Apr 7, 2020

Conversation

ajcvickers
Copy link
Member

This code is pretty stable and could potentially be used by other providers, so made selected parts public.

@ajcvickers
Clean up of pubternal usage for building/using internal service provider
f752882 
This code is pretty stable and could potentially be used by other providers, so made selected parts public.
@ajcvickers ajcvickers requested a review from a team April 5, 2020 17:55
@ajcvickers ajcvickers merged commit 26fd83c into master Apr 7, 2020
@ajcvickers ajcvickers deleted the ApplesToApples0405 branch April 7, 2020 15:59
@ajcvickers
Copy link
Member Author

Oops. Merged without making the suggested change. Will do it in a new PR.

@ajcvickers ajcvickers mentioned this pull request Apr 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajcvickers @AndriySvyryd