Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for specifying stored/virtual on computed columns #20540

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

roji
Copy link
Member

@roji roji commented Apr 5, 2020

Closes #6682

Cross-database situation

Database Stored name Virtual name Default Docs
SQL Server PERSISTED <empty> <empty> (virtual) https://docs.microsoft.com/en-us/sql/relational-databases/tables/
Sqlite STORED VIRTUAL VIRTUAL https://www.sqlite.org/gencol.html
PostgreSQL STORED VIRTUAL (not yet implemented) None, STORED must currently be specified https://www.postgresql.org/docs/12/ddl-generated-columns.html
MySQL STORED VIRTUAL VIRTUAL https://dev.mysql.com/doc/refman/5.7/en/create-table-generated-columns.html

Notes

  • tl;dr everyone calls it STORED except for SQL Server (surprise) which calls it PERSISTED. So I chose STORED as our naming.
  • This currently introduces a new ComputedColumnIsStored annotation alongside ComputedColumnSql. @AndriySvyryd I know you prefer to merge annotations where possible for perf, but I'm hesitant to encode both SQL and other info in the same annotation string. We can change the annotation format to <IsStored>,<SQL> and identify old annotations not starting with true/false and a comma, but since SQL is arbitrary SQL it seems a bit dangerous.
  • If we keep two annotations, what should be the behavior of HasComputedColumnSql accepting IConventionPropertyBuilder? Should we have two separate ones - one for the SQL annotation and another for the IsStored - or one which checks both and only updates if both are settable? Or each one if it's settable?
  • Note that this introduces a binary break by adding a default argument to HasComputedColumnSql (but recompiling is OK). If we want to avoid this we can add an overload instead.
  • Instead of a stored bool we could have a ComputedColumnType enum (Stored/Virtual), but this seems needless verbose/heavy.

@roji roji requested a review from AndriySvyryd April 5, 2020 23:48
@AndriySvyryd
Copy link
Member

For IConventionPropertyBuilder we should have two separate methods

@roji
Copy link
Member Author

roji commented Apr 12, 2020

For IConventionPropertyBuilder we should have two separate methods

Thanks, done (HasComputedColumnIsStored is somewhat weird naming but consistent etc.)

@roji roji closed this Apr 12, 2020
@roji roji reopened this Apr 12, 2020
@roji roji marked this pull request as ready for review April 12, 2020 10:21
@AndriySvyryd
Copy link
Member

IsStoredComputedColumn would be better IMO

@roji roji force-pushed the ComputedColumnTypes branch 2 times, most recently from 5233bc7 to 2f6ca83 Compare April 14, 2020 14:56
@roji
Copy link
Member Author

roji commented Apr 14, 2020

Rebased on latest master (resolving conflicts with #20602), squashed and renamed HasComputedColumnIsStored->IsStoredComputedColumn

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add validation for properties mapped to the same column

@roji
Copy link
Member Author

roji commented Apr 22, 2020

Thanks @AndriySvyryd!

@roji roji merged commit f192a90 into master Apr 22, 2020
@roji roji deleted the ComputedColumnTypes branch April 22, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying whether computed columns are stored or virtual
2 participants