Add option for specifying stored/virtual on computed columns #20540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6682
Cross-database situation
Notes
ComputedColumnIsStored
annotation alongsideComputedColumnSql
. @AndriySvyryd I know you prefer to merge annotations where possible for perf, but I'm hesitant to encode both SQL and other info in the same annotation string. We can change the annotation format to<IsStored>,<SQL>
and identify old annotations not starting with true/false and a comma, but since SQL is arbitrary SQL it seems a bit dangerous.stored
bool we could have a ComputedColumnType enum (Stored/Virtual), but this seems needless verbose/heavy.