Add query documentation in EF Core #20573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lajones
suggested changes
Apr 10, 2020
src/EFCore/Metadata/Conventions/QueryFilterDefiningQueryRewritingConvention.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Metadata/Conventions/QueryFilterDefiningQueryRewritingConvention.cs
Outdated
Show resolved
Hide resolved
lajones
approved these changes
Apr 11, 2020
src/EFCore/Query/QueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Query/QueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Query/QueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Query/QueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Query/QueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Query/QueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Query/QueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Query/QueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
requested changes
Apr 13, 2020
smitpatel
force-pushed
the
smit/lovelydocs
branch
2 times, most recently
from
6c3114c
to
fb71496
Compare
Enable warning 1591 Will do relational assembly in other pass hence disabled in that csproj. Also, Make EntityMaterializerSource public internal Make QueryableMethods to be shared internal Make IParameterValues public internal
smitpatel
force-pushed
the
smit/lovelydocs
branch
from
fb71496
to
8a54bc7
Compare
ajcvickers
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable warning 1591
Will do relational assembly in other pass hence disabled in that csproj.
Also,
Make EntityMaterializerSource public internal
Make QueryableMethods to be shared internal
Make IParameterValues public internal