Query: Add CompileQuery overloads taking upto 15 parameters #20621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Apr 14, 2020
|
Tests? |
|
Do we add test for each overload? There are 100+ of them. The upto 5 ones, we have tests for them already, which are working. |
|
At least for the ones with 15 parameters |
Resolves #20606 Upto 15 parameters are allowed. We cannot go further than that. Our return type is Func<> which does not allow more than 16 in parameters. One fixed parameter is TContext. Due to same limitation, the CompileAsyncQuery which also takes cancellationToken can support only upto 14 other parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #20606
Upto 15 parameters are allowed. We cannot go further than that. Our return type is Func<> which does not allow more than 16 in parameters. One fixed parameter is TContext.
Due to same limitation, the CompileAsyncQuery which also takes cancellationToken can support only upto 14 other parameters.