Query: Remove object convert for Contains #20628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/ExpressionTreesYouKnow
branch
from
98a95e3
to
94eb476
Compare
| @@ -33,6 +33,9 @@ public class CosmosSqlTranslatingExpressionVisitor : ExpressionVisitor | |||
| private static readonly MethodInfo _parameterListValueExtractor = | |||
| typeof(CosmosSqlTranslatingExpressionVisitor).GetTypeInfo().GetDeclaredMethod(nameof(ParameterListValueExtractor)); | |||
|
|
|||
| private static readonly MethodInfo _concatMethodInfo | |||
| = typeof(string).GetRuntimeMethod(nameof(string.Concat), new[] { typeof(object), typeof(object) }); | |||
There was a problem hiding this comment.
Should move to a shared internal class to avoid ad-hoc proliferation
AndriySvyryd
approved these changes
Apr 14, 2020
smitpatel
added a commit
that referenced
this pull request
Apr 28, 2020
smitpatel
added a commit
that referenced
this pull request
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20624