Fix to #20609 - Includes() with string throws not finding navigation path exception when type T is derived #20630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
force-pushed
the
include_warning
branch
2 times, most recently
from
e275d5c
to
92bc7de
Compare
maumar
commented
Apr 14, 2020
|
|
||
| private BugContext20609 CreateContext20609() | ||
| { | ||
| var testStore = SqlServerTestStore.CreateInitialized("QueryBugsTest", multipleActiveResultSets: true); |
There was a problem hiding this comment.
is this the right way to do custom warnings config in qbt? @AndriySvyryd
There was a problem hiding this comment.
No, but it's fine for now. Tracked by #17588
maumar
commented
Apr 14, 2020
| @@ -196,6 +197,20 @@ private enum Id | |||
| public static readonly EventId PossibleUnintendedReferenceComparisonWarning | |||
| = MakeQueryId(Id.PossibleUnintendedReferenceComparisonWarning); | |||
|
|
|||
| /// <summary> | |||
| /// <para> | |||
| /// Invalid include path '{navigationChain}', couldn't find navigation for '{navigationName}'. | |||
There was a problem hiding this comment.
"couldn't" -> "could not"?
ajcvickers
approved these changes
Apr 16, 2020
…path exception when type T is derived Fix is to use logging infrastructure for the "invalid include path" error. Log event is configured to throw by default but can be overriden in the dbcontextoptions. Event id is CoreEventId.InvalidIncludePathError
|
Unless I am missing something why the file CoreStrings.Designer.cs has changed but there are no changes in CoreStrings.resx file in this PR? |
|
@smitpatel I missed that. @maumar You probably made the changes manually, which is fine, but can we get the resx file updated to match? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix is to use logging infrastructure for the "invalid include path" error. Log event is configured to throw by default but can be overriden in the dbcontextoptions. Event id is CoreEventId.InvalidIncludePathError
Resolves #20609