Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Fix Max/Min after DefaultIfEmpty #20635

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Query: Fix Max/Min after DefaultIfEmpty #20635

merged 1 commit into from
Apr 15, 2020

Conversation

smitpatel
Copy link
Member

Resolves #20589

@smitpatel smitpatel requested a review from a team April 14, 2020 23:02
@maumar
Copy link
Contributor

maumar commented Apr 15, 2020

tests are borked

@smitpatel
Copy link
Member Author

Average does not work because types are mismatched. I need to correct SqlExpression.Type more accurately. Let me submit PR for that first.

@smitpatel smitpatel mentioned this pull request Apr 15, 2020
Closed
@smitpatel
Copy link
Member Author

Blocked on #20637
@maumar - Do you prefer to get this checked in for Min/Max and fix issue with Avg as part of #20637? It would resolve customer issue for now.

@maumar
Copy link
Contributor

maumar commented Apr 15, 2020

@smitpatel yeah, that sounds good to me, we can split the issues

@smitpatel smitpatel removed the blocked label Apr 15, 2020
@smitpatel smitpatel changed the title Query: Fix Avg/Max/Min after DefaultIfEmpty Query: Fix Max/Min after DefaultIfEmpty Apr 15, 2020
@smitpatel smitpatel merged commit 2ff24b6 into master Apr 15, 2020
@smitpatel smitpatel deleted the smit/noelementmax branch April 15, 2020 23:17
@SoftCircuits
Copy link

If this has been fixed, any way to know what version it might come out in?

@smitpatel
Copy link
Member Author

5.0.0 preview 4

@ajcvickers ajcvickers mentioned this pull request Apr 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maumar maumar maumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem to eliminating 'Sequence contains no elements' error.
3 participants
@smitpatel @maumar @SoftCircuits