API review changes #20678
Merged
API review changes #20678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Apr 18, 2020
ajcvickers
force-pushed
the
SplishSploshSplash0417
branch
from
04d9704
to
5d85022
Compare
Part of #20409 - Use Field instead of FieldInfo in model building - Change entityTypeName for `IDbSetCache.GetOrAddSet` and similar - Rename CreateKeyValueReadExpression to CreateKeyValuesExpression - Make IsQueryableType real internal - Rename IndexedProperty to IndexerProperty and related - Seal ExpressionEqualityComparer - Change ReplacingExpressionVisitor to use `IReadOnlyList<Expression>` - Use `ETag` instead of `Etag` - Remove `GetViewOrTableColumnMappings` - Rename IColumnBase.Type to StoreType
ajcvickers
force-pushed
the
SplishSploshSplash0417
branch
from
5d85022
to
a3a8f10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #20409
IDbSetCache.GetOrAddSetand similarIReadOnlyList<Expression>ETaginstead ofEtagGetViewOrTableColumnMappings