Cosmos: Detect partition key filters in queries #20690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Apr 20, 2020
...Core.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.QueryingEnumerable.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Apr 20, 2020
src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
|
Larger question, |
No, we should remove it. |
1iveowl
commented
Apr 22, 2020
...Core.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.QueryingEnumerable.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Apr 22, 2020
src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Apr 22, 2020
src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Apr 22, 2020
...Core.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.QueryingEnumerable.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Apr 22, 2020
Latest master
…ries # Conflicts: # src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs # src/EFCore.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.CosmosProjectionBindingRemovingExpressionVisitorBase.cs # src/EFCore.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.ReadItemQueryingEnumerable.cs # test/EFCore.Cosmos.FunctionalTests/EndToEndCosmosTest.cs
src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
...hapedQueryCompilingExpressionVisitor.CosmosProjectionBindingRemovingExpressionVisitorBase.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Apr 24, 2020
src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Apr 24, 2020
smitpatel
reviewed
Apr 24, 2020
smitpatel
reviewed
Apr 25, 2020
| /// </summary> | ||
| public virtual string GetPartitionKey([NotNull]IReadOnlyDictionary<string, object> parameterValues) | ||
| { | ||
| return _partitionKeyProperty != null && _paritionKeyValueExpression is ConstantExpression constantExpression |
There was a problem hiding this comment.
_partitionKeyProperty is guaranteed not-null.
There was a problem hiding this comment.
Only if set by SetPartitionKeyProperty(..).
If SetPartitionKeyProperty is never called it would be null, right?
There was a problem hiding this comment.
If _partitionKeyProperty is null you can return early
smitpatel
reviewed
Apr 25, 2020
| @@ -1012,6 +1029,156 @@ protected override ShapedQueryExpression TranslateWhere(ShapedQueryExpression so | |||
| } | |||
|
|
|||
| return null; | |||
|
|
|||
| static (Expression predicateExpression, IProperty partitionKeyProperty, Expression partitionKeyValueExpression) | |||
There was a problem hiding this comment.
This is unnecessarily complicated. I will update it when merging.
There was a problem hiding this comment.
This is unnecessarily complicated. I will update it when merging.
Agree. Thanks for helping out.
There was a problem hiding this comment.
... also cleaned it up a bit in new latest commit.
|
@AndriySvyryd - Can you sign-off on this one? I will do cleanup and merge. |
src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Apr 25, 2020
…ingExpressionVisitor.cs Co-Authored-By: Andriy Svyryd <AndriySvyryd@users.noreply.github.com>
|
@1iveowl Thanks for another contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for how to implement a partition key query detection filter.
Please see #20350