Fix for 20662. Linebreaks in HasData() in migration #20699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
approved these changes
Apr 22, 2020
| ? "@\"" + value.Replace("\"", "\"\"") + "\"" | ||
| : "\"" + value.Replace("\\", "\\\\").Replace("\"", "\\\"") + "\""; | ||
| // do not use @"" syntax as in Migrations this can get indented at a newline and so add spaces to the literal | ||
| "\"" + value.Replace(@"\", @"\\").Replace("\"", "\\\"").Replace("\n", @"\n").Replace("\r", @"\r") + "\""; |
There was a problem hiding this comment.
Can you file an issue to use verbatim strings where it makes sense? (I always wanted us to generate @"...(localdb)\MSSQLLocalDB..." in OnConfiguring)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20662
Generating the verbatim string literal syntax in the migration
HasData()and snapshotBuildModel()code where the input data had line breaks in it caused problems because the code generators would add an additional indent at the newline and hence unintentionally add spaces to the string literal.Now we generate "\r" and "\n" in non-verbatim strings instead.