Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding missing entry in CoreStrings.resx for invalid include path error/warning #20724

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Apr 23, 2020

No description provided.

@maumar maumar requested a review from lajones April 23, 2020 00:22
@@ -902,6 +902,9 @@
<value>Possible unintended reference comparison between '{left}' and '{right}'.</value>
<comment>Warning CoreEventId.PossibleUnintendedReferenceComparisonWarning object object</comment>
</data>
<data name="LogInvalidIncludePath" xml:space="preserve">
<value>Invalid include path '{navigationChain}', couldn't find navigation for '{navigationName}'.</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need the following as well:

    <comment>Error CoreEventId.InvalidIncludePathError object object</comment>

Copy link
Contributor

@lajones lajones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once <comment> is added. Thanks for the quick turnaround, @maumar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants