Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for 18063. Add missing concurrency token properties for table splitting #20748

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Fix for 18063. Add missing concurrency token properties for table splitting #20748

merged 3 commits into from
Apr 28, 2020

Conversation

lajones
Copy link
Contributor

@lajones lajones commented Apr 25, 2020 •
edited
Loading

Fixes #18063 . Previously if the user was table-splitting and one or more entity types did not map to a concurrency column, we used to throw warning the user to configure the property. Now we simply add it ourselves in shadow state.

@lajones lajones self-assigned this Apr 25, 2020
@lajones
Fix for 18063.
6f59e2f 
Added new convention to create a shadow concurrency property on the base-most entity
type(s) in table-splitting scenarios where the property would otherwise be
missing.
@lajones lajones force-pushed the 20200423_Issue18063_01 branch 3 times, most recently from c4d8ca4 to e7f93bf Compare April 27, 2020 21:53
AndriySvyryd
AndriySvyryd reviewed Apr 28, 2020
View reviewed changes
test/EFCore.Relational.Tests/Infrastructure/RelationalModelValidatorTest.cs

ConventionSet.Remove(
conventionSet.ModelFinalizingConventions,
typeof(TableSharingConcurrencyTokenConvention));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a generic argument

@lajones lajones merged commit 818c93a into master Apr 28, 2020
@lajones lajones deleted the 20200423_Issue18063_01 branch April 28, 2020 06:25
@ajcvickers ajcvickers mentioned this pull request Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees

@lajones lajones

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing concurrency token properties for table splitting
2 participants
@lajones @AndriySvyryd