Query: API Cleanup

[smitpatel]

No description provided.

[smitpatel]

@dotnet/efcore - This PR makes some API breaks & changes nullability annotations which could break functionality where API was incorrectly used. All the changes are due to incorrect API in first place. If things are done right way, then it all works. Please review, if needed, we can bring this to design meeting on Wednesday.

[roji]

See only note about niladic management in SqlFunctionExpression.

I think nullability annotation changes are fine, as we said in triage...

[smitpatel]

@AndriySvyryd - Added back obsolete methods.

Distinction is intentional. I posted alternatives if distinction is not preferred. The dislike towards distinction has nothing to do with ctor/factory methods. Please file a new issue with exact problem you are seeing.

[smitpatel]

@dotnet/aspnet-build @bricelam - What is causing incorrect names in test reporting in azure pipeline?

[ajcvickers]

With regard to obsolete methods, we should err on the side of doing them. Avoiding simple binary breaks has value--it just takes one being used by some provider/extension to prevent that provider/extension being usable without a rebuild.

[smitpatel]

Are we testing that 3.1 providers work with 5.0 EF Core? If there is going to be one API which causes break then there is no benefit of going through trouble of having 99 other API avoid break. It won't work either way.

[ajcvickers]

@smitpatel Yes, we are going to do more testing with things that currently work in 3.1.

[dougbu]

@dotnet/aspnet-build @bricelam - What is causing incorrect names in test reporting in azure pipeline?

@anurse could this be related to your recent Arcade update?