Fix for 20741. Allow older versions of tools to pass null args. #20799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lajones
changed the title
lajones
changed the title
lajones
force-pushed
the
20200430_Issue20741_01
branch
from
c591da4
to
d6adf49
Compare
AndriySvyryd
approved these changes
May 5, 2020
bricelam
reviewed
May 5, 2020
|
|
||
| _reporter = reporter; | ||
| _assembly = assembly; | ||
| _projectDir = projectDir; | ||
| _rootNamespace = rootNamespace; | ||
| _language = language; | ||
| _args = args; | ||
| _args = args ?? Array.Empty<string>(); |
There was a problem hiding this comment.
Could also just do this once in OperationExecutor's constructor
There was a problem hiding this comment.
(And leave the assert's in these classes)
There was a problem hiding this comment.
@bricelam This is already checked in. Do you think these changes are important enough for a new PR?
There was a problem hiding this comment.
Meh. We're not likely to add any new operations classes anytime soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20741
Allow older versions of tools to pass null args. This should fix @ajcvickers comment. There may still be underlying issues with
MigrationsModelDiffer.