Allow suppression of OnConfiguring() generation. #20811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for 19608. Truncate/Uniquify Sequence Names.
|
Pinging @bricelam |
bricelam
suggested changes
May 7, 2020
lajones
force-pushed
the
20200430_Issue20526_01
branch
from
9334bb6
to
2db7457
Compare
bricelam
suggested changes
May 26, 2020
Comment on lines
110
to
112
| else | ||
| { | ||
| _reporter.WriteWarning(DesignStrings.OnConfiguringWarning); |
There was a problem hiding this comment.
Suggested change
| else | |
| { | |
| _reporter.WriteWarning(DesignStrings.OnConfiguringWarning); | |
| else if (!codeOptions.SuppressOnConfiguring) | |
| { | |
| _reporter.WriteWarning(DesignStrings.SensitiveInformationWarning); |
There was a problem hiding this comment.
In other words, we shouldn't discourage OnConfiguring. Instead, we should just encourage Name=.
There was a problem hiding this comment.
@bricelam OK. Going ahead with this. What I think you're saying is we should have the --no-onconfiguring flag, but we should not point people towards it as a way of solving the problem - instead we should just mention Name= (and leave them to find --no-onconfiguring on their own if that's what they really want).
There was a problem hiding this comment.
Correct. This is the decision we made in triage.
|
@bricelam All updated as requested. I'd appreciate the final review so I can get this in. Thx. |
bricelam
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20526
Fixes #19899.
Allow suppression of
OnConfiguring()generation.