Use existing transaction identifier in RelationalConnection.UseTransaction #20844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
reviewed
May 18, 2020
| @@ -53,10 +54,30 @@ public interface IRelationalTransactionManager : IDbContextTransactionManager | |||
| /// Specifies an existing <see cref="DbTransaction" /> to be used for database operations. | |||
| /// </summary> | |||
| /// <param name="transaction"> The transaction to be used. </param> | |||
| /// <param name="transactionId"> The unique identifier for the transaction. </param> | |||
| /// <returns> An instance of <see cref="IDbTransaction" /> that wraps the provided transaction. </returns> | |||
| IDbContextTransaction UseTransaction([CanBeNull] DbTransaction transaction, Guid transactionId); | |||
There was a problem hiding this comment.
@AndriySvyryd Do you think it's worth doing a default implementation of these methods in the interface?
There was a problem hiding this comment.
No, I don't think this change breaks anything.
|
Thanks @Marusyk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add overload that takes a GUID to use for the transaction ID.
Fixes: #20828
Please review
Thank you in advance