Replace decimal with double in benchmarks #20876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build failures? |
Because Sqlite doesn't support operations on decimals (e.g. ordering) Fixes #20822
roji
force-pushed
the
NoDecimalInBenchmarks
branch
from
e6f9cfc
to
70a236c
Compare
|
again failed? |
|
This time it's Helix-only... It complains about InMemory.FunctionalTests though all test locally. Even the Helix log for it shows no failures... any idea what's going on? Should I just merge?? PS Nice to have my personal build watcher :) |
|
I wanted to approve the PR but build was not passing. Build watcher is just a subset of other watcher 😉 |
|
Enqueued another Helix build for this... But maybe we should just approve if everything is green except Helix, up to you... |
smitpatel
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Sqlite doesn't support operations on decimals (e.g. ordering)
Fixes #20822