Tests : A better infrastructure for asserting includes in the query #20958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
commented
May 14, 2020
| @@ -3971,7 +3900,7 @@ public virtual Task Multiple_SelectMany_navigation_property_followed_by_select_c | |||
| [MemberData(nameof(IsAsyncData))] | |||
| public virtual Task SelectMany_navigation_property_with_include_and_followed_by_select_collection_navigation(bool async) | |||
| { | |||
| // can't use AssertIncludeQuery here, see #18191 | |||
| // can't use AssertQuery here, see #18191 | |||
There was a problem hiding this comment.
Ignore the comment, anyway this would be found via the linked bug number.
smitpatel
commented
May 14, 2020
| // issue #15368 | ||
| //x => x.two, | ||
| AssertInclude(e.one, a.one, expectedIncludes); | ||
| AssertInclude(e.two, a.two, new ExpectedInclude<Level2>(l2 => l2.OneToOne_Optional_FK2)); |
There was a problem hiding this comment.
@maumar - Partial include solution.
Remove AssertIncludeQuery which is based on queryable Introduce AssertInclude method over element which can be used anywhere element asserter can be passed just like collection asserter Resolves #15368
maumar
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove AssertIncludeQuery which is based on queryable
Introduce AssertInclude method over element which can be used anywhere element asserter can be passed just like collection asserter
Resolves #15368