Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Use AssertQuery in NorthwindIncludeQueryTestBase #21011

Merged
merged 1 commit into from
May 26, 2020
Merged

Test: Use AssertQuery in NorthwindIncludeQueryTestBase #21011

merged 1 commit into from
May 26, 2020

Conversation

smitpatel
Copy link
Member

  • Remove string based includes from base class. (will move to a different class)
  • Remove tests related to no tracking from base class. (will move to a different class)
  • Run tests for both sync/async

Further TODO items:

  • Add a test base which converts all Includes to string includes
  • Add a test base which runs all query non-tracking
  • Modify AssertInclude to verify the IsLoaded flags.

@smitpatel smitpatel requested a review from maumar May 21, 2020 22:37
@smitpatel
Test: Use AssertQuery in NorthwindIncludeQueryTestBase
2e4997f 
- Remove string based includes from base class. (will move to a different class)
- Remove tests related to no tracking from base class. (will move to a different class)
- Run tests for both sync/async
@smitpatel smitpatel merged commit 6268c39 into master May 26, 2020
@smitpatel smitpatel deleted the smit/assertInclude branch May 26, 2020 17:34
@ajcvickers ajcvickers mentioned this pull request May 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maumar maumar maumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smitpatel @maumar