Fix for 4050. IndexAttribute. #21012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
May 22, 2020
src/EFCore/Metadata/Conventions/IndexEntityTypeAttributeConvention.cs
Outdated
Show resolved
Hide resolved
roji
reviewed
May 22, 2020
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Design/Scaffolding/Internal/CSharpDbContextGenerator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Relational.Tests/Metadata/RelationalMetadataBuilderExtensionsTest.cs
Show resolved
Hide resolved
|
After this is checked in consider allowing multiple indexes on the same properties (part of #4150) as that would break the new API introduced in this PR if done after 5.0 |
lajones
force-pushed
the
20200521_Issue4050_04
branch
from
d15886d
to
1ca8cc0
Compare
lajones
commented
May 26, 2020
lajones
force-pushed
the
20200521_Issue4050_04
branch
from
1ca8cc0
to
c6dfbe0
Compare
smitpatel
reviewed
May 26, 2020
Update error to only apply if there's a mixture of mapped and unmapped. Updating IndexAttributeConvention back to throw instead of logging.
lajones
force-pushed
the
20200521_Issue4050_04
branch
from
ba42972
to
e1230b6
Compare
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
approved these changes
May 28, 2020
This was referenced May 28, 2020
This was referenced May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4050 - allow an index to be configured using an
IndexAttribute.(Note: there's some support for TPT which doesn't work yet - marked by TODO's. I can add those in once PR #20938 is checked in).PR #20938 is checked in - TPT support now included.