[SMALL] Fix to #19801 - Query: add validation to warn about required navigations pointing to entity with query filter #21018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
changed the title
maumar
force-pushed
the
fix19801
branch
2 times, most recently
from
a344fbe
to
5ea1743
Compare
|
ping |
lajones
approved these changes
May 26, 2020
| /// <summary> | ||
| /// <para> | ||
| /// Required navigation with principal entity having global query filter defined | ||
| /// and the principal entity not having a matching filter |
There was a problem hiding this comment.
Principal mentioned twice? Should one of them be declaring?
| @@ -1375,6 +1375,10 @@ | |||
| <value>Conflicting attributes have been applied: the 'Key' attribute on property '{property}' and the 'Keyless' attribute on its entity '{entity}'. Note that the entity will have no key unless you use fluent API to override this.</value> | |||
| <comment>Warning CoreEventId.ConflictingKeylessAndKeyAttributesWarning string string</comment> | |||
| </data> | |||
| <data name="LogPossibleIncorrectRequiredNavigationWithQueryFilterInteraction" xml:space="preserve"> | |||
| <value>Entitiy '{principalEntityType}' has global query filter defined and is a required end of a relationship with the entity '{declaringEntityType}'. This may lead to unexpected results when the required entity is filtered out. Either use optional navigation or define matching query filters for both entities in the navigation. See https://go.microsoft.com/fwlink/?linkid=2131316 for more information.</value> | |||
…ons pointing to entity with query filter Warning is issued for required navigations for which required side has query filter and the optional side doesn't. When both sides define query filters we assume they are correct, i.e. we don't peek inside the filters to make sure they are consistent. Fixes #19801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning is issued for required navigations for which required side has query filter and the optional side doesn't.
When both sides define query filters we assume they are correct, i.e. we don't peek inside the filters to make sure they are consistent.
Fixes #19801