Mark owned collections composite key properties to use generated values even after the first two usages #21042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
changed the title
AndriySvyryd
approved these changes
May 27, 2020
…even after the first two usages Fixes #20932 The first time a CLR type is used as an owned collection it is not weak. Value generation is set correctly. The second time, it becomes weak, and value generation is ste correction for both usages. The first time, it is already weak, but the FK is marked as IsOwnersShip after value generation has been set. The fix to run the value generation convention again when FK ownership changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20932
The first time a CLR type is used as an owned collection it is not weak. Value generation is set correctly.
The second time, it becomes weak, and value generation is set correction for both usages.
The first time, it is already weak, but the FK is marked as IsOwnersShip after value generation has been set.
The fix to run the value generation convention again when FK ownership changes.