Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Make IPrintableExpression.Print explicit interface implementation #21063

Merged
merged 1 commit into from
May 28, 2020
Merged

Query: Make IPrintableExpression.Print explicit interface implementation #21063

merged 1 commit into from
May 28, 2020

Commits on May 27, 2020

  1. Query: Make IPrintableExpression.Print explicit interface implementation 

    Issue:
- We have Print extension method on Expression without any additional arguments.
- We also have IPrintableExpression.Print method which takes ExpressionPrinter as argument.

So when calling Print on a arbitrary expression, extension method works fine. But when calling print on a custom expression when type is known (especially in debugger), it asks to pass the ExpressionPrinter argument as it does not pick up extension method.
This is a breaking change but unlikely to cause any issues since Print method on custom expression directly should not be called.
    @smitpatel
    smitpatel committed May 27, 2020
    Configuration menu
    Copy the full SHA
    e1c2857 View commit details
    Browse the repository at this point in the history