Finish savepoints #21103
Merged
Finish savepoints #21103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
FinishSavepoints
branch
2 times, most recently
from
c76b14d
to
d7c72d2
Compare
AndriySvyryd
reviewed
Jun 2, 2020
AndriySvyryd
approved these changes
Jun 2, 2020
roji
force-pushed
the
FinishSavepoints
branch
2 times, most recently
from
eac571e
to
e71a834
Compare
Subclasses of RelationalTransaction now only have to provide the SQL to manage savepoints, and RelationalTransaction does the rest. Default SQL is defined to support most databases.
Rather than aligning with the less-than-ideal ADO.NET names (Save/Rollback/Release), switch to CreateSavepoint/RollbackToSavepoint/ ReleaseSavepoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes off the work started in #20710, see separate commits.
Closes #20176
Note that we still have the open question of whether savepoint APIs should be exposed on IDbContextTransactionManager - this is not dealt with here.
Savepoint syntax across databases
Based on the above, this PR has the following default SQL:
SAVEPOINT <name>for saveROLLBACK TO <name>for rollbackRELEASE SAVEPOINT <name>for release