Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite Spatial: Support Z and M #21130

Merged
merged 1 commit into from
Jun 5, 2020
Merged

SQLite Spatial: Support Z and M #21130

merged 1 commit into from
Jun 5, 2020

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Jun 4, 2020

Removes HasGeometricDimension. In 3.x, it was unnecessary for query, broken for SaveChanges, but did actually work in Migrations.

Use HasColumnType instead:

- x.Property(e => e.Geometry).HasGeometricDimension(Ordinates.XYZ)
+ x.Property(e => e.Geometry).HasColumnType("GEOMETRYZ")

Fixes #14257

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, happy to have the added test coverage too.

@bricelam
Copy link
Contributor Author

bricelam commented Jun 5, 2020

I discussed with the team, and we decided to just remove the APIs in 5.0

Removes `HasGeometricDimension`. Use `HasColumnType` instead.

    - x.Property(e => e.Geometry).HasGeometricDimension(Ordinates.XYZ)
    + x.Property(e => e.Geometry).HasColumnType("GEOMETRYZ")

Fixes #14257
@bricelam bricelam merged commit 49200d0 into dotnet:master Jun 5, 2020
@bricelam bricelam deleted the zim branch June 5, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving an Entity with an IPoint with Ordinates.XYZ in SpatiaLite throws an exception
2 participants