Further fix for 21089. Some missed NotNulls. #21138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Jun 4, 2020
|
@smitpatel Are you OK with the changes? |
|
Posted an iteration on old PR about incorrect CanBeNull and some missing Check.NotNull. LGTM with those changes. |
lajones
force-pushed
the
20200604_Issue21089_09
branch
from
94be95c
to
f9b6d7c
Compare
|
@AndriySvyryd @smitpatel Thanks for keeping me honest through all the changes. It was good to have a 2nd and 3rd pair of eyes on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments in PR #21115 (for issue #21089). Missed some
[NotNull]statements. Plus minor docs change.