Specific message for method translation failure #21178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
approved these changes
Jun 8, 2020
ilmax
reviewed
Jun 9, 2020
roji
force-pushed
the
MethodTranslationMessage
branch
from
c530a3c
to
2589734
Compare
smitpatel
reviewed
Jun 9, 2020
| Assert.Equal( | ||
| @"The LINQ expression 'DbSet<CollectionScalar>() .Where(c => c.Tags .Any())' could not be translated. Either rewrite the query in a form that can be translated, or switch to client evaluation explicitly by inserting a call to either AsEnumerable(), AsAsyncEnumerable(), ToList(), or ToListAsync(). See https://go.microsoft.com/fwlink/?linkid=2101038 for more information.", | ||
| Assert.Contains( | ||
| @"Either rewrite the query in a form that can be translated, or switch to client evaluation explicitly by inserting a call to either AsEnumerable(), AsAsyncEnumerable(), ToList(), or ToListAsync(). See https://go.microsoft.com/fwlink/?linkid=2101038 for more information.", |
There was a problem hiding this comment.
This was by design. We should verify exception message for query as much as we can with Equal so that we know exactly what we are printing as Expression tree to user.
There was a problem hiding this comment.
We were already checking only a substring via QueryTestBase.AssertTranslationFailed, and @maumar seemed to think this change was OK. Strong feelings about this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21177