Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Refactor shaper processing for relational #21181

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Query: Refactor shaper processing for relational #21181

merged 1 commit into from
Jun 10, 2020

Conversation

smitpatel
Copy link
Member

  • This makes is single pass, end to end processing.
  • This is required since split queries need to integrate a processed shaper inside a client method while working on outer shaper.

@smitpatel smitpatel mentioned this pull request Jun 9, 2020
Merged
AndriySvyryd
AndriySvyryd approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to do this for Cosmos too? 😄

@smitpatel
Copy link
Member Author

I will think about Cosmos later. There could be some refactoring there also which can make it "simpler".

@smitpatel smitpatel force-pushed the smit/queryablerefactor branch 2 times, most recently from 7ef8a16 to 17b24cb Compare June 10, 2020 05:44
Base automatically changed from smit/queryablerefactor to feature/splitInclude June 10, 2020 06:22
@smitpatel
Query: Refactor shaper processing for relational
cd453bd 
- This makes is single pass, end to end processing.
- This is required since split queries need to integrate a processed shaper inside a client method while working on outer shaper.
@smitpatel smitpatel mentioned this pull request Jun 10, 2020
Open
64 tasks
@smitpatel smitpatel merged commit 4f2c7ce into feature/splitInclude Jun 10, 2020
@smitpatel smitpatel deleted the smit/combination branch June 10, 2020 07:32
@ajcvickers ajcvickers mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@maumar maumar Awaiting requested review from maumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smitpatel @AndriySvyryd