Ignore comments in SQL composability check #21188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
reviewed
Jun 9, 2020
maumar
approved these changes
Jun 9, 2020
And rewrite without regex Fixes #18412
roji
force-pushed
the
MoreSqlComposability
branch
from
cc35fd2
to
67ee793
Compare
ErikEJ
reviewed
Jun 9, 2020
roji
force-pushed
the
MoreSqlComposability
branch
from
91c03bb
to
f369490
Compare
roji
force-pushed
the
MoreSqlComposability
branch
from
f369490
to
6d50960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And rewrite without regex
Fixes #18412